Use const initializer for LOCAL_PANIC_COUNT #92461

bjorn3 · 2021-12-31T17:42:34Z

This reduces the size of the __getit function for LOCAL_PANIC_COUNT and should speed up accesses of LOCAL_PANIC_COUNT a bit.

rust-highfive · 2021-12-31T17:42:37Z

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

Mark-Simulacrum · 2021-12-31T17:59:05Z

@bors r+ rollup=never (plausible perf effect, but should be positive or neutral)

bors · 2021-12-31T17:59:06Z

📌 Commit 6e4c3b1 has been approved by Mark-Simulacrum

bors · 2022-01-01T09:07:26Z

⌛ Testing commit 6e4c3b1 with merge 64aaec50341510cde64227a2f67a73d8be26a35e...

bors · 2022-01-01T09:10:09Z

💔 Test failed - checks-actions

bjorn3 · 2022-01-01T10:28:37Z

curl: (6) Could not resolve host: ci-mirrors.rust-lang.org

@bors retry spurious network error

bors · 2022-01-01T17:15:51Z

⌛ Testing commit 6e4c3b1 with merge 4484eacdad2cfbdfbfa56fbcb413dac1723889ff...

bors · 2022-01-01T17:34:08Z

💔 Test failed - checks-actions

bjorn3 · 2022-01-01T17:47:50Z

Why does the unsafe_op_in_unsafe_fn lint trigger inside thread_local!{} here?

bjorn3 · 2022-01-10T11:39:11Z

Seems that const thread_local! was missing a couple of unsafe {} blocks.

bjorn3 · 2022-01-10T11:39:31Z

@rustbot ready

library/std/src/thread/local.rs

bors · 2022-04-02T05:19:32Z

☔ The latest upstream changes (presumably #95581) made this pull request unmergeable. Please resolve the merge conflicts.

bjorn3 · 2022-04-02T18:51:36Z

@rust-lang/infra For some reason the x86_64-gnu-llvm-12, job got canceled. I tried rerunning it but then @github-actions canceled it again. Any idea what could be going on?

bors · 2022-04-13T16:22:33Z

☔ The latest upstream changes (presumably #95727) made this pull request unmergeable. Please resolve the merge conflicts.

This reduces the size of the __getit function for LOCAL_PANIC_COUNT and should speed up accesses of LOCAL_PANIC_COUNT a bit.

bjorn3 · 2022-04-23T10:10:38Z

Rebased

JohnTitor · 2022-05-22T07:36:35Z

r? @Mark-Simulacrum as you reviewed previously

Mark-Simulacrum · 2022-05-23T12:59:30Z

@bors r+

bors · 2022-05-23T12:59:32Z

📌 Commit cbc0a15 has been approved by Mark-Simulacrum

bors · 2022-05-23T13:05:02Z

⌛ Testing commit cbc0a15 with merge ef9b498...

bors · 2022-05-23T15:45:38Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ef9b498 to master...

rust-timer · 2022-05-23T17:04:36Z

Finished benchmarking commit (ef9b498): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: mixed results

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	1	2	0	1	1
mean²	2.0%	1.3%	N/A	-1.5%	2.0%
max	2.0%	1.5%	N/A	-1.5%	2.0%

Cycles

Results

Primary benchmarks: 😿 relevant regression found
Secondary benchmarks: 😿 relevant regressions found

	Regressions 😿 (primary)	Regressions 😿 (secondary)	Improvements 🎉 (primary)	Improvements 🎉 (secondary)	All 😿 🎉 (primary)
count¹	1	3	0	0	1
mean²	1.9%	2.5%	N/A	N/A	1.9%
max	1.9%	2.8%	N/A	N/A	1.9%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

number of relevant changes ↩ ↩²
the arithmetic mean of the percent change ↩ ↩²

bjorn3 added the A-thread-locals Area: Thread local storage (TLS) label Dec 31, 2021

rust-highfive assigned joshtriplett Dec 31, 2021

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 31, 2021

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 31, 2021

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 1, 2022

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2022

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 1, 2022

This comment has been minimized.

Sign in to view

bjorn3 mentioned this pull request Jan 10, 2022

@rustbot ready comment ignored rust-lang/triagebot#1551

Closed

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2022

goffrie reviewed Mar 1, 2022

View reviewed changes

library/std/src/thread/local.rs Outdated Show resolved Hide resolved

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2022

bjorn3 force-pushed the const_tls_local_panic_count branch from 8a0c633 to bfd45e0 Compare April 2, 2022 18:25

Use const initializer for LOCAL_PANIC_COUNT

cbc0a15

This reduces the size of the __getit function for LOCAL_PANIC_COUNT and should speed up accesses of LOCAL_PANIC_COUNT a bit.

bjorn3 force-pushed the const_tls_local_panic_count branch from bfd45e0 to cbc0a15 Compare April 23, 2022 10:10

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 23, 2022

JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2022

rust-highfive assigned Mark-Simulacrum and unassigned joshtriplett May 22, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 23, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label May 23, 2022

bors merged commit ef9b498 into master May 23, 2022

bors deleted the const_tls_local_panic_count branch May 23, 2022 15:45

rustbot added this to the 1.63.0 milestone May 23, 2022

Use const initializer for LOCAL_PANIC_COUNT #92461

Use const initializer for LOCAL_PANIC_COUNT #92461

Uh oh!

Conversation

bjorn3 commented Dec 31, 2021

Uh oh!

rust-highfive commented Dec 31, 2021

Uh oh!

Mark-Simulacrum commented Dec 31, 2021

Uh oh!

bors commented Dec 31, 2021

Uh oh!

bors commented Jan 1, 2022

Uh oh!

bors commented Jan 1, 2022

Uh oh!

This comment has been minimized.

bjorn3 commented Jan 1, 2022

Uh oh!

bors commented Jan 1, 2022

Uh oh!

bors commented Jan 1, 2022

Uh oh!

This comment has been minimized.

bjorn3 commented Jan 1, 2022

Uh oh!

bjorn3 commented Jan 10, 2022

Uh oh!

bjorn3 commented Jan 10, 2022

Uh oh!

Uh oh!

bors commented Apr 2, 2022

Uh oh!

bjorn3 commented Apr 2, 2022

Uh oh!

bors commented Apr 13, 2022

Uh oh!

bjorn3 commented Apr 23, 2022

Uh oh!

JohnTitor commented May 22, 2022

Uh oh!

Mark-Simulacrum commented May 23, 2022

Uh oh!

bors commented May 23, 2022

Uh oh!

bors commented May 23, 2022

Uh oh!

bors commented May 23, 2022

Uh oh!

rust-timer commented May 23, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

Uh oh!

Uh oh!